Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openfga): Allow extra labels specific to pods #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grimly
Copy link

@grimly grimly commented Dec 31, 2024

This PR provides the ability to add labels to openfga pods.

Description

Some mechanisms such as Network Policies or Webhooks uses the concept of LabelSelector. This PR adds a podExtraLabels value next to the podAnnotations so that extra labels can be added to the openfga pods.

This change was validated through snapshot testing in an internal fork.
There is no testing framework in place here. Providing the mentioned snapshot testing framework is out of this PR's scope so I won't check the last box.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@grimly grimly requested review from a team as code owners December 31, 2024 09:16
Copy link

linux-foundation-easycla bot commented Dec 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: grimly / name: Michel TURPIN (f937d01)

These labels can be used by LabelSelectors (ie: network policies, webhooks)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant