Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add quotes around oidc options #153

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: add quotes around oidc options #153

merged 1 commit into from
Aug 14, 2024

Conversation

danielloader
Copy link
Contributor

@danielloader danielloader commented Aug 13, 2024 •
edited by rhamzeh
Loading

Description

Added quotes to ensure the environment variable value is always treated as a string. Zitadel and Azure seemingly offer audiences that are longInts.

References

closes #152

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@danielloader danielloader requested review from a team as code owners August 13, 2024 14:43
@evansims evansims merged commit dc7f103 into openfga:main Aug 14, 2024
4 checks passed
@danielloader danielloader deleted the add-quotes-oidc-options branch August 14, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numeric audiences can't be set for OIDC authn
2 participants
@danielloader @evansims