Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace existing github release creation #234

Closed
wants to merge 1 commit into from

Conversation

ewanharris
Copy link
Member

Description

Given the issue with the existing action around newlines, I figured it was worth a quick look into replacing it.

The existing action uses a tool called submark to parse the changelog for the release body, this offers an action that we can use to do the same and then feed the output of that into a maintained action for creating a release (we've used this before in Auth0 SDKs).

This is entirely untested so is in draft status, if we decide we wanna give it a try then I will experiment on a personal repo to ensure I have a working flow before attempting to roll out.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims
Copy link
Member

evansims commented Apr 9, 2024

Nice. Yeah, this Action worked very reliably for us on the Auth0 SDKs and never had any issues.

@ewanharris
Copy link
Member Author

I'm going to close this PR out as I did some testing of the submark action and it appears we can't pin to a commit sha or version, which doesn't align with our requirements for using GH actions

@ewanharris ewanharris closed this May 8, 2024
@ewanharris ewanharris deleted the ci/change-gh-release-creation branch May 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants