fix(moncaco/validate): handle metadata being undefined #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
force-pushed
the
fix/handle-undefined-metadata
branch
from
141543f to
be3dfa3
Compare
ewanharris
commented
Jan 25, 2024
ewanharris
commented
Jan 25, 2024
rhamzeh
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's possible for an error returned from the
validateDSLmethod inlanguageto return no metadata (1, 2), based on documentation/the source code from ANTRL this would indicate that the error arose from the lexer but unfortunately I've not been able to come up with a case where I can reproduce this to write a test from.That said, based on the error shown in Sentry and the surrounding code this is a fairly certain fix for the issue.
References
Review Checklist
main