-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for start time in read changes request #92
base: main
Are you sure you want to change the base?
feat: Support for start time in read changes request #92
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (32.71%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 33.00% 32.71% -0.29%
==========================================
Files 128 129 +1
Lines 6387 6467 +80
Branches 840 850 +10
==========================================
+ Hits 2108 2116 +8
- Misses 4099 4171 +72
Partials 180 180 ☔ View full report in Codecov by Sentry. |
this.ContextualTuples.SequenceEqual(input.ContextualTuples) | ||
) && | ||
( | ||
this.Context == input.Context || |
Check warning
Code scanning / CodeQL
Reference equality test on System.Object Warning
this
/// <param name="input">Object to be compared</param> | ||
/// <returns>Boolean</returns> | ||
public override bool Equals(object input) { | ||
return this.Equals(input as ForbiddenResponse); |
Check warning
Code scanning / CodeQL
Equals should not apply "as" Warning
( | ||
this.Code == input.Code || | ||
this.Code.Equals(input.Code) | ||
) && | ||
( | ||
this.Message == input.Message || | ||
(this.Message != null && | ||
this.Message.Equals(input.Message)) | ||
) | ||
&& (this.AdditionalProperties.Count == input.AdditionalProperties.Count && !this.AdditionalProperties.Except(input.AdditionalProperties).Any()); |
Check notice
Code scanning / CodeQL
Complex condition Note
Description
Pulls updates from sdk-generator after latest release and adds support for start time in read changes
References
openfga/sdk-generator#455
openfga/sdk-generator#420
openfga/sdk-generator#398
Review Checklist
main