Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for start time in read changes request #92

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ryanpq
Copy link
Contributor

@ryanpq ryanpq commented Feb 6, 2025

Description

Pulls updates from sdk-generator after latest release and adds support for start time in read changes

References

openfga/sdk-generator#455
openfga/sdk-generator#420
openfga/sdk-generator#398

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ryanpq ryanpq requested review from a team as code owners February 6, 2025 16:39
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 13.09524% with 73 lines in your changes missing coverage. Please review.

Project coverage is 32.71%. Comparing base (7d634fa) to head (8baeae7).

Files with missing lines Patch % Lines
src/OpenFga.Sdk/Model/ForbiddenResponse.cs 0.00% 49 Missing ⚠️
src/OpenFga.Sdk/Model/Assertion.cs 22.72% 17 Missing ⚠️
src/OpenFga.Sdk/Model/ReadRequest.cs 0.00% 6 Missing ⚠️
src/OpenFga.Sdk/Client/Client.cs 0.00% 0 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (32.71%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   33.00%   32.71%   -0.29%     
==========================================
  Files         128      129       +1     
  Lines        6387     6467      +80     
  Branches      840      850      +10     
==========================================
+ Hits         2108     2116       +8     
- Misses       4099     4171      +72     
  Partials      180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

this.ContextualTuples.SequenceEqual(input.ContextualTuples)
) &&
(
this.Context == input.Context ||

Check warning

Code scanning / CodeQL

Reference equality test on System.Object Warning

Reference equality for System.Object comparisons (
this
argument has type Object).
/// <param name="input">Object to be compared</param>
/// <returns>Boolean</returns>
public override bool Equals(object input) {
return this.Equals(input as ForbiddenResponse);

Check warning

Code scanning / CodeQL

Equals should not apply "as" Warning

ForbiddenResponse.Equals(object) should not use "as" on its parameter, as it will not work properly for subclasses of ForbiddenResponse.
Comment on lines +101 to +110
(
this.Code == input.Code ||
this.Code.Equals(input.Code)
) &&
(
this.Message == input.Message ||
(this.Message != null &&
this.Message.Equals(input.Message))
)
&& (this.AdditionalProperties.Count == input.AdditionalProperties.Count && !this.AdditionalProperties.Except(input.AdditionalProperties).Any());

Check notice

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants