Allow override of http port and loadBalancerIP with new helm values

[LeviTrammell]

Signed-off-by: Levi Trammell [email protected]

Description

I've added a couple of new helm values :

.Values.gatewayExternal.loadBalancerIP
.Values.gatewayExternal.port

If the gatewayExternal.loadBalancerIP is set and the service is of type LoadBalancer, one can explicitly set which IP the external gateway service uses. This is not an uncommon practice with people of the homelab community using MetalLB or kube-vip.

If the gatewayExternal.port is set, the gateway service can use whatever port it wants (say port 80), and continue using the target port of 8080. If gatewayExternal.port is not set it falls back to the default port 8080.

These changes will make it super simple for someone to set these value using helm or arkade.

Motivation and Context

• I have raised an issue to propose this change (required)

#941

How Has This Been Tested?

Tested as described in documentation.

helm upgrade openfaas --install ~/Developer/faas-netes/chart/openfaas \
    --namespace openfaas \
    --set functionNamespace=openfaas-fn \
    --set generateBasicAuth=true \
    -f ~/Developer/faas-netes/chart/openfaas/values.yaml \
    -f ~/Developer/faas-netes/chart/openfaas/values-arm64.yaml \
    -f ./values.yaml

Here is the values.yaml that I used

serviceType: LoadBalancer

gatewayExternal:
  port: 80
  loadBalancerIP: 10.49.0.9

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[alexellis]

We'll triage this request and talk about it on the next community call, however we do not encourage use of openfaas without TLS, the LoadBalancer is for AWS users who have a TLS-terminating load balancer available to them.

You should consider using TLS with cert-manager, inlets may also be of use to you, you'll have to figure that out.

https://blog.alexellis.io/tls-the-easy-way-with-openfaas-and-k3sup/