Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build options examples #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ivanayov
Copy link
Contributor

This adds an example how to use build-option with pillow for Python

Signed-off-by: Ivana Yovcheva (VMware) [email protected]

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please share with community for someone to try it out before the merge. Think it should also be higher in the document. Nearer top

@alexellis
Copy link
Member

We have a slight conflict now @ivanayov due to some ordering changes. Please can you rebase or re-submit in a new PR?

Alex

docs/cli/build.md Outdated Show resolved Hide resolved
@ivanayov ivanayov force-pushed the pillow branch 2 times, most recently from 6f6a0dc to 157c93a Compare July 17, 2018 16:30
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs improvements, please.

@alexellis
Copy link
Member

@ivanayov PTAL.

@ivanayov
Copy link
Contributor Author

@alexellis I've changed the code example.
The build is successful locally, so the checks should not fail from the changes

@alexellis
Copy link
Member

Anything left to do here @ivanayov ? cc @rgee0 please could you review and check you are happy before a merge?

@ivanayov
Copy link
Contributor Author

@alexellis since the last update I don't have anything to add/change, unless there are new comments on the PR

This adds an example of how to practically use `build-option`
with pillow for Python

Signed-off-by: Ivana Yovcheva (VMware) <[email protected]>
@ivanayov
Copy link
Contributor Author

@alexellis conflicts from master are now resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants