Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note for kubernetes constraints/nodeSelectors #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertgroh
Copy link

@robertgroh robertgroh commented Mar 12, 2021

Description

The Kubernetes operator faas-netes expects the constraints / nodeSelectors in the format <label-key>=<label-value>.

References:

also remove some erroneous white space in an URL, which broke the link and anchor

Motivation and Context

Clarify the constraints format for different container orchestrators, as this is stumbling block for some users, see openfaas/faas-netes #406: Help needed with constraints

How Has This Been Tested?

I looked over the rendered markdown.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Improve Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@alexellis
Copy link
Member

Thanks for the PR. We do need to remove those references to Swarm, it seems like a good time to do that.

You may also find profiles useful for your use-case

If you could squash your two commits down, I'll try to get this merged when I get the follow-up notification.

Given that the use-case sounds like work/commercial, do checkout the GitHub Sponsors options that we have for individual practitioners like yourself.

Alex

The Kubernetes operator `faas-netes` expects the constraints / nodeSelectors in the format <label-key>=<label-value>.

references:
  - pull request ([Node selector support via constraints openfaas#77](openfaas/faas-netes#77)), which introduced the feature
  - the [source code for the createSelector function](https://github.com/openfaas/faas-netes/blame/master/pkg/handlers/deploy.go#L338), see how the key-value pair is split
  - an [issue](openfaas/faas-netes#406 (comment)) regarding the difference between constraints for Docker Swarm & Kubernetes

also:
  - fix broken link/anchor
    by removing erroneous whitespace in the URL

Signed-off-by: Robert Groh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants