-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update .releaserc
to publish from appropriate branches
#3337
ci: update .releaserc
to publish from appropriate branches
#3337
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
{ "name": "alpha", "prerelease": true }, | ||
{ "name": "beta", "prerelease": true } | ||
{ "name": "release-22.x", "range": "22.x", "channel": "22.x" }, | ||
{ "name": "release-23.x", "range": "23.x" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understand the channel
docs (https://semantic-release.gitbook.io/semantic-release/usage/workflow-configuration#channel) correctly this should make it so the release-23.x
branch publishes to the @latest
tag on npm
{ "name": "beta", "prerelease": true } | ||
{ "name": "release-22.x", "range": "22.x", "channel": "22.x" }, | ||
{ "name": "release-23.x", "range": "23.x" }, | ||
{ "name": "next", "prerelease": true, "channel": "next" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure how prerelease
and channel
interact, but of all things to "test in prod" about this config it feels the least scary.
"next", | ||
{ "name": "alpha", "prerelease": true }, | ||
{ "name": "beta", "prerelease": true } | ||
{ "name": "release-22.x", "range": "22.x", "channel": "22.x" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://semantic-release.gitbook.io/semantic-release/usage/workflow-configuration, this should make it so
name
: we're looking at therelease-22.x
branchrange
: this only publishes releases in the22.x
range of semantic versionschannel
: these releases are published to the22.x
tag onnpm
b2883b7
to
77fbd1e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #3337 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 229 229
Lines 3836 3836
Branches 916 916
=======================================
Hits 3599 3599
Misses 230 230
Partials 7 7 ☔ View full report in Codecov by Sentry. |
closing in favor of #3341 |
Description
see #3272
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?Post-merge Checklist