Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update .releaserc to publish from appropriate branches #3337

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Dec 10, 2024

Description

see #3272

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 77fbd1e
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6758707ba224c400086540c6
😎 Deploy Preview https://deploy-preview-3337--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

{ "name": "alpha", "prerelease": true },
{ "name": "beta", "prerelease": true }
{ "name": "release-22.x", "range": "22.x", "channel": "22.x" },
{ "name": "release-23.x", "range": "23.x" },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understand the channel docs (https://semantic-release.gitbook.io/semantic-release/usage/workflow-configuration#channel) correctly this should make it so the release-23.x branch publishes to the @latest tag on npm

{ "name": "beta", "prerelease": true }
{ "name": "release-22.x", "range": "22.x", "channel": "22.x" },
{ "name": "release-23.x", "range": "23.x" },
{ "name": "next", "prerelease": true, "channel": "next" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure how prerelease and channel interact, but of all things to "test in prod" about this config it feels the least scary.

"next",
{ "name": "alpha", "prerelease": true },
{ "name": "beta", "prerelease": true }
{ "name": "release-22.x", "range": "22.x", "channel": "22.x" },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://semantic-release.gitbook.io/semantic-release/usage/workflow-configuration, this should make it so

  • name: we're looking at the release-22.x branch
  • range: this only publishes releases in the 22.x range of semantic versions
  • channel: these releases are published to the 22.x tag on npm

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.82%. Comparing base (e96baef) to head (77fbd1e).
Report is 192 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #3337   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files         229      229           
  Lines        3836     3836           
  Branches      916      916           
=======================================
  Hits         3599     3599           
  Misses        230      230           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril
Copy link
Contributor Author

closing in favor of #3341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants