-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Toast
children prop type
#3232
base: master
Are you sure you want to change the base?
fix: Toast
children prop type
#3232
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3232 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 249 249
Lines 4401 4401
Branches 1033 1033
=======================================
Hits 4105 4105
Misses 290 290
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@rpenido Thanks for fixing this. Is it ready for review? |
Yes! It is ready now. |
Co-authored-by: Braden MacDonald <[email protected]>
@bradenmacdonald Fixed! |
@rpenido This is going to require some more input while we decide whether |
Description
This is a small fix of the typing for the
children
prop of theToast
component. This was generating some warnings in thefrontend-app-course-authoring
when theToast
was used with anElement
instead of astring
.Example (from here):
Deploy Preview
https://deploy-preview-3232--paragon-openedx.netlify.app/components/toast/
Merge Checklist
example
app?Post-merge Checklist