-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore touchstart
events for closing modal popups
#3087
fix: ignore touchstart
events for closing modal popups
#3087
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3087 +/- ##
=======================================
Coverage 93.20% 93.21%
=======================================
Files 249 249
Lines 4359 4363 +4
Branches 1000 1037 +37
=======================================
+ Hits 4063 4067 +4
+ Misses 293 290 -3
- Partials 3 6 +3 ☔ View full report in Codecov by Sentry. |
83ca0c2
to
65bc658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once we've verified the solution is cross-browser compatible as discussed in Paragon Working Group, at least according to the supported browsers in browserslist-config
(source).
I have verified this on: safari-ios-17.webm I didn't test all 3 latest versions of Firefox and Chrome on Android, instead I just tested the third oldest, but I am confident this testing is enough to show the fix works. |
🎉 This PR is included in version 22.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Resolves #3081
react-focus-on
was picking uptouchstart
events foronClickOutside
- resulting inonClose
being called before theclick
event was sent to the button. This PR just wraps the call toonClose
in a small function that filters outtouchstart
events.Deploy Preview
https://deploy-preview-3087--paragon-openedx.netlify.app/components/modal/modal-popup/
Merge Checklist
example
app?Post-merge Checklist