Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: fixed changelog genereation #2605

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Sep 7, 2023

Description

  • fixed changelog generation.

Issue

Deploy Preview

Paragon changelog

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Sep 7, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a9dfc2
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64fa2a3c034faa0008762111
😎 Deploy Preview https://deploy-preview-2605--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b39a6a4) 91.69% compared to head (6a9dfc2) 91.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2605   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         235      235           
  Lines        4214     4214           
  Branches     1021     1021           
=======================================
  Hits         3864     3864           
  Misses        346      346           
  Partials        4        4           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@viktorrusakov
Copy link
Contributor

I don't think this fully fixes the issue, because the changelog will become stale very quickly again. Previously we used @semantic-release/changelog plugin to automatically populate changelog file with new releases data, but we turned it off due to CLA issue, see #1768. We should fix that as well as a part of this PR.

@adamstankiewicz I believe we can avoid CLA issues by changing git author in semantic-release configuration to someone who has necessary rights to the repo, can you maybe try that?

@viktorrusakov viktorrusakov linked an issue Sep 8, 2023 that may be closed by this pull request
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft September 15, 2023 13:20
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review September 15, 2023 13:20
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft October 30, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BD-46] Legacy changelog
4 participants