-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] sync master with alpha branch #2231
Conversation
…e and result count (#2011)
* feat: added npm workspaces * refactor: code refactoring * chore: add example app to npm workspaces * style: remove circular dependencies * refactor: refactoring after review * refactor: added test * refactor: refactoring start script * chore: update script to use workspaces --------- Co-authored-by: Viktor Rusakov <[email protected]>
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. |
# Conflicts: # example/package-lock.json # example/package.json # package-lock.json # src/Button/README.md # src/DataTable/_variables.scss # src/DataTable/filters/TextFilter.jsx # src/Dropdown/README.md # src/Dropdown/index.jsx # src/Modal/index.jsx # src/StatusAlert/index.jsx # src/Table/index.jsx # src/Tabs/README.md # src/ValidationFormGroup/index.jsx # www/src/components/Header.scss # www/src/components/Menu.tsx # www/src/pages/foundations/elevation.tsx
a12bda5
to
8570521
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2231 +/- ##
==========================================
+ Coverage 90.94% 91.06% +0.11%
==========================================
Files 214 214
Lines 3523 3524 +1
Branches 852 853 +1
==========================================
+ Hits 3204 3209 +5
+ Misses 311 307 -4
Partials 8 8 ☔ View full report in Codecov by Sentry. |
@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.0.0-alpha.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist