-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds CourseAboutPageURLRequested and LMSPageURLRequested filters #200
feat: adds CourseAboutPageURLRequested and LMSPageURLRequested filters #200
Conversation
Thanks for the pull request, @jignaciopm! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @jignaciopm! Just flagging there's a failing check here. |
0ba2879
to
e95d591
Compare
d89aac4
to
7a594a9
Compare
7a594a9
to
059143c
Compare
@jignaciopm: Thanks again for addressing our comments! I reviewed this one last time and made some changes for you to review: 4b77aae. I'll approve this PR once you apply them. The changes are mainly focused on using I'm sorry for the back and forth. |
059143c
to
bdfaba6
Compare
Thank you @mariajgrimaldi the change was applied there. Tell me if you agree how it looks now to apply this change in openedx/edx-platform#35142 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you again for addressing all of our comments. Please, feel free to apply the changes in the places needed.
I'll merge this once you add an entry to the changelog and update the openedx_filters/__init__.py
file with the new version.
bdfaba6
to
8403c8b
Compare
Description: Describe in a couple of sentences what this PR adds
This adds the TenantAwareLinkRenderStarted filter which receive a string context with LMS url to allowing the filter pipeline to return the information that we need to filter, in this case a tenant aware link from Studio to LMS.
An example of use is in eox-tenant custom filter step pipeline, where it takes the LMS_ROOT_URL and return only the tenant aware link in the respective site.
JIRA: DS-1003
Dependencies:
openedx/edx-platform#35142
Merge deadline: N/A
Installation instructions:
Be sure to use edx-platform branch with changes openedx/edx-platform#35142
Testing instructions:
The change can be tested with testing instructions in eduNEXT/eox-tenant#156.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns:
N/A