-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for loading external theme CSS for MFEs #689
Open
dcoa
wants to merge
24
commits into
openedx:master
Choose a base branch
from
eduNEXT:dcoa/design-tokens-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 26, 2024
-
feat: add ability to dynamically load theme overrides
feat: adds support for loading external theme CSS for MFEs Introduces `useAppTheme` in `AppProvider` to load/inject `<link>` elements for the core theme CSS and any theme variant CSS into the HTML document. Exposes the app theme state and a way to mutate it to consumers via `AppContext`. fix: handle missing theme config fix: add env vars to env files fix: remove unused code chore: wip commit fix: prefer runtime config for paragon theme fix: rebase on master and resolve package conflicts fix: revert to original webpack.dev.config config chore: clean up unnecessary comment line fix: grammar Co-authored-by: Adolfo R. Brandes <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a28be3 - Browse repository at this point
Copy the full SHA 8a28be3View commit details -
chore: refresh package-lock.json to lockfileVersion 3 fix: clean up link nodes in document head when no longer needed fix: fallback to locally installed core and light theme css urls docs: update to docs chore: update docs about fix: expose setThemeVariant
Configuration menu - View commit details
-
Copy full SHA for 4727a2f - Browse repository at this point
Copy the full SHA 4727a2fView commit details -
fix: rebase with master and update based on PARAGON changes chore: remove support for env vars config for paragon dynamic theming
Configuration menu - View commit details
-
Copy full SHA for 0eb957e - Browse repository at this point
Copy the full SHA 0eb957eView commit details -
fix: updates fix: one more update fix: refresh package-lock.json fix: refresh package-lock.json pt2 fix: updates fix: update package-lock.json fix: make it theme variant agnostic docs: update howto theming guide fix: ensure app loads without styles if the PARAGON_THEME_URLS and fallback urls all fail to load fix: ensure fallback theme links are removed if they also error docs: add link to mfe runtime config api adr fix: don't attempt to load paragon css urls if PARAGON_THEME_URLS is absent
Configuration menu - View commit details
-
Copy full SHA for 02b9b08 - Browse repository at this point
Copy the full SHA 02b9b08View commit details -
docs: fix code example docs: add missing comma docs: update how to
Configuration menu - View commit details
-
Copy full SHA for 17c0b8c - Browse repository at this point
Copy the full SHA 17c0b8cView commit details -
chore: update package-lock.json chore: update package-lock.json take 2 chore: remove console.log statements fix: ignore system preference change when theme variant set in localstorage chore: add tests for updates to AppProvider chore: update react-intl to pass peer dependencies after pinning all deps chore: split hooks.js up into separate files and begin some related tests test: add testing to useParagonTheme hooks (openedx#514) * test: add testing to useParagonThemeCore * test: add test to useThemeVariants hook * fix: Paragon definition and remove onload mock * test: change test message to be clear
Configuration menu - View commit details
-
Copy full SHA for cd88107 - Browse repository at this point
Copy the full SHA cd88107View commit details -
Configuration menu - View commit details
-
Copy full SHA for b64c154 - Browse repository at this point
Copy the full SHA b64c154View commit details -
Configuration menu - View commit details
-
Copy full SHA for d934ec7 - Browse repository at this point
Copy the full SHA d934ec7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d170103 - Browse repository at this point
Copy the full SHA d170103View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89104fd - Browse repository at this point
Copy the full SHA 89104fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0445ee2 - Browse repository at this point
Copy the full SHA 0445ee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33aba81 - Browse repository at this point
Copy the full SHA 33aba81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd20a1 - Browse repository at this point
Copy the full SHA 5dd20a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba3f639 - Browse repository at this point
Copy the full SHA ba3f639View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c0ea76 - Browse repository at this point
Copy the full SHA 4c0ea76View commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ea2c6a - Browse repository at this point
Copy the full SHA 7ea2c6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65144e0 - Browse repository at this point
Copy the full SHA 65144e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a269c5d - Browse repository at this point
Copy the full SHA a269c5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e66dc4 - Browse repository at this point
Copy the full SHA 4e66dc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2bfe7c - Browse repository at this point
Copy the full SHA b2bfe7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e1da80 - Browse repository at this point
Copy the full SHA 2e1da80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f84e1c - Browse repository at this point
Copy the full SHA 8f84e1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae5b53f - Browse repository at this point
Copy the full SHA ae5b53fView commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3576ee7 - Browse repository at this point
Copy the full SHA 3576ee7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.