refactor: remove prop-types from peerDep and install in dep #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 61.87% // Head: 61.87% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 15 15
Lines 299 299
Branches 70 70
=======================================
Hits 185 185
Misses 112 112
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Mashal-m
force-pushed
the
mashal-m/remove_props-type_from_peerdep
branch
from
f955441
to
0de98ab
Compare
|
I don't have any objections, but just curious: what motivated you to do this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove prop-types from peer-dependencies and install it in dependencies.