-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: picker component to only post message with block info [FC-0062] #1401
refactor: picker component to only post message with block info [FC-0062] #1401
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The picker component will not call any api on selection.
b5e64e1
to
b91d86d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
- Coverage 93.13% 93.12% -0.01%
==========================================
Files 1050 1050
Lines 20163 20140 -23
Branches 4269 4269
==========================================
- Hits 18778 18755 -23
Misses 1322 1322
Partials 63 63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great, thanks! I tested this with the corresponding platform PR and it's working well.
If there's any follow-up improvements needed (e.g. to fix the button situation as I commented on the other PR), please just open a new PR.
Description
The picker component will not call any api on selection.
Supporting information
For: openedx/edx-platform#35670
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.