-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: layout responsive for edit page #922
base: master
Are you sure you want to change the base?
fix: layout responsive for edit page #922
Conversation
Thanks for the pull request, @ihor-romaniuk! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #922 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 708 708
Lines 12588 12589 +1
Branches 2724 2758 +34
=======================================
+ Hits 11636 11637 +1
Misses 915 915
Partials 37 37 ☔ View full report in Codecov by Sentry. |
Hi @ihor-romaniuk - would you be able to address the branch conflicts that have popped up? |
4e3480d
to
81f54ba
Compare
@mphilbrick211 PR was updated and ready for review. Thanks. |
Hi @openedx/2u-tnl! This is ready for review. Thanks! |
Friendly follow-up on this, @openedx/2u-tnl! |
@openedx/2u-tnl following up on this! |
Hi @openedx/2u-tnl! Is someone able to please review / merge this? Thanks! |
TL;DR -
This pull request contains mobile phone adaptation fixes for Problem Editor page.
Added general rearrangement of pages, indentations, and fixed element deformation during adaptation.
Related PRs:
What changed?