Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout responsive for edit page #1058

Conversation

ihor-romaniuk
Copy link
Contributor

TL;DR -

This pull request contains mobile phone adaptation fixes for Problem Editor page.
Added general rearrangement of pages, indentations, and fixed element deformation during adaptation.

Related PRs:

What changed?

Before After
12 11
Before After
41 21

@ihor-romaniuk ihor-romaniuk requested a review from a team as a code owner May 30, 2024 11:06
@openedx-webhooks
Copy link

openedx-webhooks commented May 30, 2024

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/redwood.master@a63409e). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             open-release/redwood.master    #1058   +/-   ##
==============================================================
  Coverage                               ?   92.27%           
==============================================================
  Files                                  ?      708           
  Lines                                  ?    12496           
  Branches                               ?     2715           
==============================================================
  Hits                                   ?    11531           
  Misses                                 ?      928           
  Partials                               ?       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label May 31, 2024
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jul 30, 2024
Copy link
Contributor

@rayzhou-bit rayzhou-bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in hosted devstack. Exit confirmation looks great! Multi-select problem unfortunately does not display properly on mobile at the moment so that portion did not come across on testing.

@rayzhou-bit rayzhou-bit merged commit 65e431c into openedx:open-release/redwood.master Sep 25, 2024
6 checks passed
rayzhou-bit added a commit that referenced this pull request Sep 25, 2024
rayzhou-bit added a commit that referenced this pull request Sep 25, 2024
@rayzhou-bit
Copy link
Contributor

Hi @ihor-romaniuk I accidentally merged this change in. I reverted it after. Could you create another PR and I'll approve it?

@itsjeyd itsjeyd removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants