Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve library sidebar tab while switching items #1538

Closed
rpenido opened this issue Nov 28, 2024 · 2 comments
Closed

Preserve library sidebar tab while switching items #1538

rpenido opened this issue Nov 28, 2024 · 2 comments

Comments

@rpenido
Copy link
Contributor

rpenido commented Nov 28, 2024

Reported by @sdaitzman on Slack:

When switching between selecting different components, the active sidebar tab is preserved. When switching between selecting collections and components, the tab always switches to the first available one (preview for components, manage for collections).

Screen.Recording.2024-11-27.at.2.42.17.PM.mov

Since there are different tabs, I think it would be preferable to:

  • Keep the same tab active if it still exists in the new sidebar (i.e. when the Details/Manage is active for a component, and a collection is selected, show that component’s same Details/Manage sidebar tab)
  • If the active tab does not exist in the new sidebar (Preview tab for component sidebar), show the first (Manage) tab; when switching selection back to a component, return to the Preview tab
@rpenido rpenido moved this to In Progress in Libraries Overhaul Nov 28, 2024
@rpenido rpenido moved this from In Progress to Ready for AC testing in Libraries Overhaul Dec 6, 2024
@rpenido
Copy link
Contributor Author

rpenido commented Dec 6, 2024

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@sdaitzman
Copy link

Looks great to me!

@github-project-automation github-project-automation bot moved this from Ready for AC testing to Done in Libraries Overhaul Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants