-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preserve library sidebar tab while switching items #1535
feat: preserve library sidebar tab while switching items #1535
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
=======================================
Coverage 92.91% 92.92%
=======================================
Files 1066 1066
Lines 20988 21000 +12
Branches 4538 4544 +6
=======================================
+ Hits 19501 19514 +13
- Misses 1414 1419 +5
+ Partials 73 67 -6 ☔ View full report in Codecov by Sentry. |
@rpenido I should have mentioned this to you earlier, but in #1499 we want to start putting a lot more of the state into URLs, so please keep that in mind while working on this. You don't have to implement it now, but try to implement this in a way that will make it easier to do that in the near future. |
e448d50
to
07e6790
Compare
Act! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: (describe what you tested)
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
Description
This PR makes the selected tab on the sidebar persist while selecting Components or Collections.
More information
Testing instruction
Private ref: FAL-3980