Skip to content

Commit

Permalink
fix: use string literals for library accessLevel
Browse files Browse the repository at this point in the history
  • Loading branch information
pomegranited committed Oct 14, 2024
1 parent 9041907 commit a0e0d84
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
6 changes: 3 additions & 3 deletions src/library-authoring/data/api.mocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,17 +356,17 @@ export async function mockGetLibraryTeam(libraryId: string): Promise<api.Library
mockGetLibraryTeam.adminMember = {
username: 'admin-user',
email: '[email protected]',
accessLevel: 'admin',
accessLevel: 'admin' as api.LibraryAccessLevel,
};
mockGetLibraryTeam.authorMember = {
username: 'author-user',
email: '[email protected]',
accessLevel: 'author',
accessLevel: 'author' as api.LibraryAccessLevel,
};
mockGetLibraryTeam.readerMember = {
username: 'reader-user',
email: '[email protected]',
accessLevel: 'read',
accessLevel: 'read' as api.LibraryAccessLevel,
};
mockGetLibraryTeam.notMember = {
username: 'not-user',
Expand Down
8 changes: 5 additions & 3 deletions src/library-authoring/data/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,16 +96,18 @@ export interface ContentLibrary {
updated: string | null;
}

export type LibraryAccessLevel = 'read' | 'author' | 'admin';

export interface LibraryTeamMember {
username: string;
email: string;
accessLevel: string;
accessLevel: LibraryAccessLevel,
}

export interface AddLibraryTeamMember {
libraryId: string,
email: string;
accessLevel: string;
accessLevel: LibraryAccessLevel,
}

export interface DeleteLibraryTeamMember {
Expand All @@ -114,7 +116,7 @@ export interface DeleteLibraryTeamMember {
}

export interface UpdateLibraryTeamMember extends DeleteLibraryTeamMember {
accessLevel: string;
accessLevel: LibraryAccessLevel,
}

export interface Collection {
Expand Down
5 changes: 3 additions & 2 deletions src/library-authoring/library-team/LibraryTeam.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import AlertError from '../../generic/alert-error';
import Loading from '../../generic/Loading';
import { ToastContext } from '../../generic/toast-context';
import { useLibraryContext } from '../common/context';
import { LibraryAccessLevel } from '../data/api';
import {
useContentLibrary,
useLibraryTeam,
Expand Down Expand Up @@ -61,7 +62,7 @@ const LibraryTeam: React.FC<Record<never, never>> = () => {
libraryId,
email,
// New members are created as Readers
accessLevel: LibraryRole.Reader.toString(),
accessLevel: LibraryRole.Reader.toString() as LibraryAccessLevel,
}).then(() => {
showToast(intl.formatMessage(messages.addMemberSuccess));
}).catch(() => {
Expand All @@ -78,7 +79,7 @@ const LibraryTeam: React.FC<Record<never, never>> = () => {
updateMember.mutateAsync({
libraryId,
username,
accessLevel: role.toString(),
accessLevel: role.toString() as LibraryAccessLevel,
}).then(() => {
showToast(intl.formatMessage(messages.updateMemberSuccess));
}).catch(() => {
Expand Down

0 comments on commit a0e0d84

Please sign in to comment.