feat: include content_price in Algolia indexed course_runs for course objects
#943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
force-pushed
the
ags/run-based-content-price
branch
from
967b917
to
f362639
Compare
adamstankiewicz
commented
Sep 16, 2024
| @@ -25,11 +25,15 @@ | |||
| PAST_COURSE_RUN_UUID_1 = uuid4() | |||
|
|
|||
|
|
|||
| def _fake_upgrade_deadline(days_from_now=0): | |||
| def _days_from_now(days_from_now=0): | |||
There was a problem hiding this comment.
[inform] Rename carried over from #912
adamstankiewicz
changed the title
content_price in Algolia indexed course_runs for course objects
adamstankiewicz
commented
Sep 16, 2024
Comment on lines
-102
to
+107
| def course(self): | ||
| return self.instance.get('course') | ||
| def course_metadata(self): | ||
| return self.instance.get('course_metadata') | ||
|
|
||
| @cached_property | ||
| def course_metadata(self): | ||
| return self.course.json_metadata | ||
| def is_exec_ed_2u_course(self): | ||
| return self.course_metadata.get('course_type') == EXEC_ED_2U_COURSE_TYPE |
There was a problem hiding this comment.
[inform] To support using NormalizedContentMetadataSerializer where only the metadata for course is available vs. the actual database ContentMetadata object itself, consumers must pass in course_metadata: course_record.json_metadata instead of having the serializer attempt to parse json_metadata.
As a result, the helper property is_exec_ed_2u_course that exists on the ContentMetadata model is accounted for here as well such that the get_content_price can still utilize it.
adamstankiewicz
force-pushed
the
ags/run-based-content-price
branch
from
f362639
to
374dfb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-9504
course_runslist indexed in Algolia course objects containscontent_price.enroll_byfor the indexedcourse_runsfromNormalizedContentMetadataSerializervs. largely replicating the same logic in multiple places (DRY).Post-review