feat: Remove DEPR waffle switch: ENABLE_GLOBAL_STAFF_OPTIMIZATION

[marslanabdulrauf]

Description

This PR removes the DEPR waffle switch ENABLE_GLOBAL_STAFF_OPTIMIZATION and its usage.

Supporting information

https://github.com/mitodl/hq/issues/6346
#35649

[openedx-webhooks]

Thanks for the pull request, @marslanabdulrauf!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[asadali145]

LGTM!

[asadali145]

This is unused. Can be removed.

[pdpinch]

Couple of small things:

1. needs a rebase
2. please include the name of the waffle flag in the commit message, ENABLE_GLOBAL_STAFF_OPTIMIZATION
3. Unless you disagree, I think this should be feat! with the ! indicating a breaking change.

[marslanabdulrauf]

After this merge tests are failing as forked repositories don't have access to original repo secrets

This will be affecting all opensourse-contribution PRs

Cc @pdpinch

[kdmccormick]

I'll take a look at the CI issue in a couple of hours.

[kdmccormick]

This should be fixed now. Re-running your unit tests...

[marslanabdulrauf]

Thanks so much, @kdmccormick, I truly appreciate your help and swift action.

[robrap]

1. Please replace all uses of "waffle flag" with "waffle switch" in comments and on this PR (including the title).
2. Please update the PR title with the toggle name as well (as was done with the commit).
   Thank you!

[pdpinch]

I am tempted to try out this new button I have "enable auto-merge" with the expectation that it won't actually merge until the branch is rebased.

But let's not take that chance. @marslanabdulrauf would mind rebasing this again and I'll plan to merge it between 8am and 9am EST tomorrow.