-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Video editor supports transcripts [FC-0076] #36058
Open
ChrisChV
wants to merge
24
commits into
openedx:master
Choose a base branch
from
open-craft:chris/FAL-3989-video-transcripts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+417
−174
Open
Changes from 17 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9cdf45f
feat: Updates to support save video with transcript in library home
ChrisChV 3885dd1
style: Fix lint
ChrisChV a723e96
feat: Updated code to get english transcript from filename
ChrisChV 1c2a575
style: Fix lint
ChrisChV 74f027f
feat: Upload transcript file as static asset in Learning Core in libr…
ChrisChV 2adacee
style: Fix lint
ChrisChV 0393829
feat: Updates to support download transcripts from youtube in vlibrar…
ChrisChV e27221e
style: Fix lint
ChrisChV 05067f6
test: Add test for download youtube transcripts in library content
ChrisChV 2f53a75
style: Fix lint
ChrisChV 5c6819a
feat: Support copy transcripts from a library
ChrisChV 95b51e8
refactor: Allow use edx_video_id (edxval) in new runtime
ChrisChV c42e223
refactor: Adds new edx_video_id when copy to course
ChrisChV 4bf3af3
refactor: Remove unnevessary code
ChrisChV 1de1d4e
feat: Support delete transcripts in library
ChrisChV a59898d
style: Fix lint
ChrisChV 9173ed8
Merge branch 'master' into chris/FAL-3989-video-transcripts
ChrisChV 590a5cd
style: Nits on the code
ChrisChV 0e54450
refactor: Update replace_transcript to verify transcript
ChrisChV 5685f16
refactor: Verify LibraryLocatorV2 in manage_video_subtitles_save to a…
ChrisChV e4f7c72
style: Add comment in transcripts_ajax.py
ChrisChV b478ac5
refactor: _get_item to avoid return isLibraryContent
ChrisChV 173a0af
refactor: studio_transcript to separate methods in separated functions
ChrisChV 4532a2a
refactor: Update code in video_handlers to avoid "static/None"
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing a bug when I sync a LibraryBlock video with transcripts from an upstream video.
Steps to reproduce:
Note that the transcripts are displaying fine here.
Note that the upstream video preview shows its transcripts fine, but the downstream (course) video preview doesn't show its transcripts anymore.
Note that the course video no longer shows its transcripts, but if you edit it, you can see they're still there.
Syncing.upstream.video.breaks.transcripts.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is related to openedx/modular-learning#246
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisChV That could very well be.. however I don't think it's resolved by @DanielVZ96 's #36173, but it's also possible that I didn't merge conflicts accurately. cf my merged branch.