Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra fields to ORA staff graded serializer #33507

Closed

Conversation

nandodev-net
Copy link

@nandodev-net nandodev-net commented Oct 16, 2023

feat: endpoint /api/ora_staff_grader/initialize upgraded

Peek 2023-10-13 20-47

Implementation Details

This PR adds the fullname and email fields to the /api/ora_staff_grader/initialize endpoint.
Modifications were made in the following directories:

edx-platform

  • lms/djangoapps/ora_staff_grader/serializers.py

ORA2

  • openassessment/staffgrader/serializers/submission_list.py
  • openassessment/staffgrader/staff_grader_mixin.py
  • openassessment/data.py

This upgrade will consist of two PRs: one for ORA and the other for edx-platform. This is because the main serializer of the service resides in the platform. To test it, you'll need to fetch and set up the version of the platform with the serializer modification.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 16, 2023

Thanks for the pull request, @nandodev-net! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@nandodev-net nandodev-net changed the title feat: endpoint /api/ora_staff_grader/initialize upgraded (platform main serializer) feat: endpoint /api/ora_staff_grader/initialize upgraded Oct 16, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2023
@nandodev-net nandodev-net changed the title feat: endpoint /api/ora_staff_grader/initialize upgraded feat: add extra fields to ORA staff graded serializer Oct 16, 2023
@nandodev-net nandodev-net force-pushed the FG/ORA_staff_grader_endpoints branch from 620876f to 12b1c6b Compare October 16, 2023 20:27
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@mphilbrick211
Copy link

Hi @nandodev-net! Just checking to see if you plan to pursue this pull request?

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Feb 21, 2024
@mphilbrick211
Copy link

Closing this for now. We can reopen in the future if needed.

@openedx-webhooks
Copy link

@nandodev-net Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants