Handle type in CourseMode min_price #26508
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-1632.
Background:
The
min_price
column in LMSCourseMode
table takes integers, and should be updated to take decimals to match the price in ecommerce database, making the price across the learner pathway to purchase the same (49.99 vs. 49).This ticket covers:
Before (2) is deployed in ecommerce, LMS must be able to handle receiving the price data as a non-integer. Originally had this check before
.save()
inCourseMode
model, but per Emma's point, would be better to check this earlier - now inCourseRetrieveUpdateView
(urls.py uses this view) forcommerce API
.In order to decrease the risk of breaking anything with migrations, this change will be divided into 5 steps across edx-platform and ecommerce:
min_price
can receive non-int.min_price
value.min_price
column.