-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edx-ora2 | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #2238
edx-ora2 | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #2238
Conversation
- Drop support for python 3.8 and add support for python 3.11 and 3.12
a3a6b0c
to
ad7695b
Compare
Hi @ttqureshi -- I'm working my way through the PR backlog for this repo, apologies for letting this one go stale! |
sure |
conflicts resolved |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2238 +/- ##
==========================================
+ Coverage 95.23% 95.29% +0.05%
==========================================
Files 195 195
Lines 21606 21624 +18
Branches 1502 1502
==========================================
+ Hits 20576 20606 +30
+ Misses 784 771 -13
- Partials 246 247 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for this change @ttqureshi -- it works perfectly.
One nit re the version bump, and could you update the tests to fix coverage?
- I tested this in my tutor dev stack using the Demo course in Studio, LMS, and Preview
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
0f7a34d
to
3593c0b
Compare
Hi @ttqureshi -- I'm not sure why I have to keep allowing the CI to run here, but I bet it's frustrating to have to wait for me to know when you've fixed all the errors :( You can run the tests locally using tox, e.g.
If you want to run the 3.12 tests, use python 3.12 to create your virtualenv. |
Thanks @pomegranited for the heads-up! I’ll run the tests locally with tox to catch any errors before pushing. |
098c1a3
to
7bbf574
Compare
@ttqureshi we're so close now! |
So close @ttqureshi ! Just need a little more code coverage -- the easiest way to spot the missing lines is to look for the inline codecov warnings like these. |
alright 👍 |
@pomegranited I hope it's done now :) |
@ttqureshi Tests are all green now! Thank you so much for persisting with this change. Merging now :) |
Overview
This PR:
pkg_resources
api fromimportlib_resources
api. (resolves Move on from deprecated pkg_resources api #2225)python 3.8
and add support forpython 3.11
. (resolves Drop Python 3.8 & Add Support for Python 3.12 #2230)Tickets:
Screenshots