chore: fix studio base view #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcarter
reviewed
Oct 17, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/2023-dual-ui #2078 +/- ##
====================================================
Coverage ? 94.96%
====================================================
Files ? 189
Lines ? 19433
Branches ? 1766
====================================================
Hits ? 18455
Misses ? 738
Partials ? 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jansenk
approved these changes
Oct 17, 2023
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
* chore: fix studio base view * chore: update translation
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
* chore: fix studio base view * chore: update translation
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
* chore: fix studio base view * chore: update translation
nsprenkle
added a commit
that referenced
this pull request
Nov 7, 2023
Add support for multiple UIs, currently legacy and a new MFE view. Includes: * make: legacy template (#2046) * chore: add lms+cms restart script to install-local-ora * refactor: move data gathering pieces of mixins into xblock/apis * feat: new xblock/ui_mixins/legacy to replace existing view/handler behaviors from mixins, leveraging our new APIs. * refactor: remaining non-core-xblock functionality from xblock to xblock/utils. Updated references to changed file locations. * feat: add page context MFE endpoint * refactor: allow peeking a peer assessment * chore: update translations * feat: Add logic to display the new ORA UI templates (#2054) * feat: xblock iframe * feat: conditional render of new views based on mobile or waffle * feat: BFF Assessments Data (#2063) * feat: add url generation to file parsing * refactor: legacy upload files * refactor: legacy delete file * refactor: legacy file upload url generation * refactor: has any files in upload space * chore: fix studio base view (#2078) * docs: update some comments / docstrings * fix: add missing teams step * feat: xblock view (#2080) * feat: disable MFE views for unsupported use-cases (#2090) * feat: refactor legacy assessment actions and add assessment mfe bff handler (#2074) * refactor: legacy peer assessment handler and api action * refactor: legacy self assessment api handler * refactor: legacy staff assessment handler and api action * refactor: legacy student training handler and api action * refactor: legacy ui mixins folder structure * refactor: peer review uuid matching * feat: get_active_assessment peer api function --------- Co-authored-by: Nathan Sprenkle <[email protected]> Co-authored-by: Jenkins <[email protected]> Co-authored-by: Ben Warzeski <[email protected]> Co-authored-by: Leangseu Kim <[email protected]>
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
* chore: fix studio base view * chore: update translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge to feat/2023-dual-ui
TLDR;
base.htmlexist in bothedx-platformandedx-ora2. It confuse for which to use forcms.What change?
base.htmlto subdirectionopenassessmentblock