feat: refactor legacy assessment actions and add assessment mfe bff handler #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansenk
changed the base branch from
feat/2023-dual-ui
to
jkantor/bff-file-actions
jansenk
force-pushed
the
jkantor/assess-actions-mfe
branch
from
44ba76a to
07652e5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/2023-dual-ui #2074 +/- ##
====================================================
Coverage ? 94.26%
====================================================
Files ? 192
Lines ? 20426
Branches ? 1854
====================================================
Hits ? 19255
Misses ? 916
Partials ? 255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Base automatically changed from
jkantor/bff-file-actions
to
feat/2023-dual-ui
October 16, 2023 15:17
jansenk
force-pushed
the
jkantor/assess-actions-mfe
branch
from
4db0c30 to
dccdf74
Compare
jansenk
changed the title
jansenk
requested review from
leangseu-edx,
mattcarter,
muselesscreator and
nsprenkle
jansenk
force-pushed
the
jkantor/assess-actions-mfe
branch
from
8542bdd to
025558e
Compare
nsprenkle
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Mostly looks good, with the following caveats:
- I initial page context load should also fetch a submission to assess. Proposing refactor to
get_peer_submissionto check if you have an active one and return that, else get a new one. - Trying to understand why refactors include moving files around.
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
…andler (#2074) * refactor: legacy peer assessment handler and api action * refactor: legacy self assessment api handler * refactor: legacy staff assessment handler and api action * refactor: legacy student training handler and api action * refactor: legacy ui mixins folder structure * refactor: peer review uuid matching * feat: mfe handler to submit assessment * test: add tests and style cleanup for mfe assessment handler * feat: get_active_assessment peer api function * feat: auto-pull peer unless jumping
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
…andler (#2074) * refactor: legacy peer assessment handler and api action * refactor: legacy self assessment api handler * refactor: legacy staff assessment handler and api action * refactor: legacy student training handler and api action * refactor: legacy ui mixins folder structure * refactor: peer review uuid matching * feat: mfe handler to submit assessment * test: add tests and style cleanup for mfe assessment handler * feat: get_active_assessment peer api function * feat: auto-pull peer unless jumping
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
…andler (#2074) * refactor: legacy peer assessment handler and api action * refactor: legacy self assessment api handler * refactor: legacy staff assessment handler and api action * refactor: legacy student training handler and api action * refactor: legacy ui mixins folder structure * refactor: peer review uuid matching * feat: mfe handler to submit assessment * test: add tests and style cleanup for mfe assessment handler * feat: get_active_assessment peer api function * feat: auto-pull peer unless jumping
nsprenkle
added a commit
that referenced
this pull request
Nov 7, 2023
Add support for multiple UIs, currently legacy and a new MFE view. Includes: * make: legacy template (#2046) * chore: add lms+cms restart script to install-local-ora * refactor: move data gathering pieces of mixins into xblock/apis * feat: new xblock/ui_mixins/legacy to replace existing view/handler behaviors from mixins, leveraging our new APIs. * refactor: remaining non-core-xblock functionality from xblock to xblock/utils. Updated references to changed file locations. * feat: add page context MFE endpoint * refactor: allow peeking a peer assessment * chore: update translations * feat: Add logic to display the new ORA UI templates (#2054) * feat: xblock iframe * feat: conditional render of new views based on mobile or waffle * feat: BFF Assessments Data (#2063) * feat: add url generation to file parsing * refactor: legacy upload files * refactor: legacy delete file * refactor: legacy file upload url generation * refactor: has any files in upload space * chore: fix studio base view (#2078) * docs: update some comments / docstrings * fix: add missing teams step * feat: xblock view (#2080) * feat: disable MFE views for unsupported use-cases (#2090) * feat: refactor legacy assessment actions and add assessment mfe bff handler (#2074) * refactor: legacy peer assessment handler and api action * refactor: legacy self assessment api handler * refactor: legacy staff assessment handler and api action * refactor: legacy student training handler and api action * refactor: legacy ui mixins folder structure * refactor: peer review uuid matching * feat: get_active_assessment peer api function --------- Co-authored-by: Nathan Sprenkle <[email protected]> Co-authored-by: Jenkins <[email protected]> Co-authored-by: Ben Warzeski <[email protected]> Co-authored-by: Leangseu Kim <[email protected]>
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
…andler (openedx#2074) * refactor: legacy peer assessment handler and api action * refactor: legacy self assessment api handler * refactor: legacy staff assessment handler and api action * refactor: legacy student training handler and api action * refactor: legacy ui mixins folder structure * refactor: peer review uuid matching * feat: mfe handler to submit assessment * test: add tests and style cleanup for mfe assessment handler * feat: get_active_assessment peer api function * feat: auto-pull peer unless jumping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - - Add mfe BFF handler for submitting assessments
JIRA: AU-1302
What changed?
FYI: @openedx/content-aurora