feat: add extra fields to ORA staff graded serializer

[nandodev-net]

feat: endpoint /api/ora_staff_grader/initialize upgraded

Implementation Details

This PR adds the fullname and email fields to the /api/ora_staff_grader/initialize endpoint.
Modifications were made in the following directories:

ORA2

• openassessment/staffgrader/serializers/submission_list.py
• openassessment/staffgrader/staff_grader_mixin.py
• openassessment/data.py

edx-platform

• lms/djangoapps/ora_staff_grader/serializers.py

This upgrade will consist of two PRs: one for ORA and the other for edx-platform. This is because the main serializer of the service resides in the platform. To test it, you'll need to fetch and set up the version of the platform with the serializer modification.

• Platform PR link: feat: add extra fields to ORA staff graded serializer  edx-platform#33507

[openedx-webhooks]

Thanks for the pull request, @nandodev-net! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

[mariajgrimaldi]

Suggested change

[itsjeyd]

Hey @nandodev-net, thank you for this contribution! Let us know when the changes are ready for review.

[jansenk]

This looks good, but one style change and one suggested simplification improvement

[jansenk]

style nit

Suggested change

	from openassessment.data import (OraSubmissionAnswerFactory, VersionNotFoundException, map_anonymized_ids_to_emails,
	map_anonymized_ids_to_fullname, map_anonymized_ids_to_usernames)
	from openassessment.data import (
	OraSubmissionAnswerFactory,
	VersionNotFoundException,
	map_anonymized_ids_to_emails,
	map_anonymized_ids_to_fullname,
	map_anonymized_ids_to_usernames
	)

[jansenk]

Here's an idea, rather than having these all be separate, and adding a new function every time we want more user data, why not do something like

def map_anonymized_ids_to_user_data(anonymized_ids):
    """
    Args:
        anonymized_ids - list of anonymized user ids.
    Returns:
        dict {
           <anonymous_user_id> : {
               'email': (str) <user.email>
               'username': (str) <user.username>
               'fullname': (str) <user.profile.name>
            }
        }
        """
       User = get_user_model()

    users = _use_read_replica(
        User.objects.filter(anonymoususerid__anonymous_user_id__in=anonymized_ids)
        .select_related("profile")
        .annotate(
            anonymous_id=F("anonymoususerid__anonymous_user_id")),
            fullname=F("profile__name"),
        )
        .values("username", "email", "fullname", "anonymous_id")
    )

    anonymous_id_to_user_info_mappnig = {
        user["anonymous_id"]: user for user in users
    }
    return anonymous_id_to_user_info_mapping

[mariajgrimaldi]

I like that idea. If we make this change, we'd also need to modify: https://github.com/openedx/edx-ora2/pull/2076/files#diff-4708da322d3d3b03cd269f5aa9574e7b1708cd6e665f1c25b2ba2570ca18dfefR98-R113 (and probably more) so we keep the implementation consistent.

[jansenk]

Sorry, that was meant to be a "comment" rather than a "request changes"

[itsjeyd]

@nandodev-net It looks like your changes already went through a round of engineering review. Once you're done addressing the feedback, can you mark this PR as ready (= remove it from Draft state)?

[itsjeyd]

Hey @nandodev-net, just checking in to see if you're still planning to continue working on this PR?

[itsjeyd]

Hi @nandodev-net! Just a quick update that we're closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work.

[openedx-webhooks]

@nandodev-net Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.