-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup #474
chore: cleanup #474
Conversation
Thanks for the pull request, @CodeWithEmad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4fbc4e9
to
4a50851
Compare
Thank you for this contribution @CodeWithEmad! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I made one small comment, which you can take or leave.
CHANGELOG.rst
Outdated
- removed openedx.yaml file | ||
|
||
- Added new catalog-info field ``openedx.org/release`` | ||
- Removed openedx.yaml file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what style guide you're following (if any), but it seems like you added code formatting to file names in other places. Do you want to add it here?
i.e.
- Removed openedx.yaml file | |
- Removed ``openedx.yaml`` file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, @pdpinch. I'll fix it.
4a50851
to
06dd06b
Compare
@pdpinch Thanks for jumping in and providing a review for this PR! Would you be able to merge the changes or will we need to ask for help from Axim for that? @CodeWithEmad Could you please look into why some of the automated tests are failing? |
See #475 (comment) |
See #475 (comment) |
@CodeWithEmad Now that #471 has been merged I'm removing the blocker label. Back to you for now. Once the build is green we should be good to merge this. |
- edx -> Open edX - trailing whitespace removed - rst cleanup in changelog
06dd06b
to
84c9a15
Compare
@itsjeyd Done |
@CodeWithEmad Great! @feanil Since this repo is unmaintained could you please do the honors and merge the changes? They were approved via #474 (review). |
This just cleans the repo readme and some newlines in
.in
files,.in
requirements files.