Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #474

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: cleanup #474

merged 1 commit into from
Nov 7, 2024

Conversation

CodeWithEmad
Copy link
Member

This just cleans the repo readme and some newlines in .in files,

  • edx -> Open edX
  • trailing whitespace removed.
  • new lines in .in requirements files.

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 29, 2024

Thanks for the pull request, @CodeWithEmad!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 29, 2024
@CodeWithEmad CodeWithEmad marked this pull request as ready for review July 29, 2024 11:10
@CodeWithEmad CodeWithEmad force-pushed the chore/cleanup branch 2 times, most recently from 4fbc4e9 to 4a50851 Compare August 1, 2024 09:15
@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Aug 8, 2024
@itsjeyd
Copy link

itsjeyd commented Aug 8, 2024

Thank you for this contribution @CodeWithEmad!

Copy link

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I made one small comment, which you can take or leave.

CHANGELOG.rst Outdated
- removed openedx.yaml file

- Added new catalog-info field ``openedx.org/release``
- Removed openedx.yaml file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what style guide you're following (if any), but it seems like you added code formatting to file names in other places. Do you want to add it here?

i.e.

Suggested change
- Removed openedx.yaml file
- Removed ``openedx.yaml`` file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @pdpinch. I'll fix it.

@itsjeyd itsjeyd removed needs reviewer assigned PR needs to be (re-)assigned a new reviewer waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Sep 20, 2024
@itsjeyd itsjeyd requested a review from pdpinch September 20, 2024 12:05
@itsjeyd
Copy link

itsjeyd commented Sep 20, 2024

@pdpinch Thanks for jumping in and providing a review for this PR!

Would you be able to merge the changes or will we need to ask for help from Axim for that?

@CodeWithEmad Could you please look into why some of the automated tests are failing?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 20, 2024
@CodeWithEmad
Copy link
Member Author

See #475 (comment)

@itsjeyd
Copy link

itsjeyd commented Sep 26, 2024

See #475 (comment)

@itsjeyd
Copy link

itsjeyd commented Oct 11, 2024

Same here, marking as blocked on #471.

@itsjeyd itsjeyd added blocked by other work PR cannot be finished until other work is complete and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 11, 2024
@itsjeyd
Copy link

itsjeyd commented Oct 31, 2024

@CodeWithEmad Now that #471 has been merged I'm removing the blocker label. Back to you for now. Once the build is green we should be good to merge this.

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed blocked by other work PR cannot be finished until other work is complete labels Oct 31, 2024
@itsjeyd itsjeyd mentioned this pull request Oct 31, 2024
- edx -> Open edX
- trailing whitespace removed
- rst cleanup in changelog
@CodeWithEmad
Copy link
Member Author

@itsjeyd Done

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 7, 2024
@itsjeyd
Copy link

itsjeyd commented Nov 7, 2024

@CodeWithEmad Great!

@feanil Since this repo is unmaintained could you please do the honors and merge the changes? They were approved via #474 (review).

@feanil feanil merged commit 90ca184 into openedx:master Nov 7, 2024
5 checks passed
@CodeWithEmad CodeWithEmad deleted the chore/cleanup branch November 9, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants