feat: management command allowing you to revoke certificates #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows revocation of certificates. It defaults to program_certificates, which is the most likely use case, but because some UserCredentials might not be synchronized from the LMS, does allow override of the credential type. * Adds a new model and django admin so this script can be run in an automated fashion * this required bringing in config_models FIXES: APER-3799
fixing import sorting FIXES: APER-3799
some improvement to test coverage FIXES: APER-3799
improved test coverage, and as a side effect, improved the actual code FIXES: APER-3799
ran isort FIXES: APER-3799
justinhynes
reviewed
Dec 5, 2024
credentials/apps/credentials/management/commands/revoke_certificates.py
Outdated
Show resolved
Hide resolved
modifying the comment FIXES: APER-3799
justinhynes
reviewed
Dec 5, 2024
| with self.assertRaisesRegex(CommandError, expected): | ||
| call_command(Command(), "--lms_user_ids", "8675309", "--credential_id", "123") | ||
|
|
||
| # real user, doesn't mapped to a real credential |
There was a problem hiding this comment.
nit: map over mapped in this comment
justinhynes
reviewed
Dec 5, 2024
requirements/all.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.11 | |||
| # This file is autogenerated by pip-compile with Python 3.12 | |||
There was a problem hiding this comment.
Has Credentials been upgraded to use Python 3.12? I thought we were still only using 3.11.
There was a problem hiding this comment.
regenerating with my devstack version of Python, thanks
regenerating with devstack version of Python to make sure I have the correct version FIXES: APER-3799
justinhynes
approved these changes
Dec 5, 2024
deborahgu
deleted the
dkaplan1/APER-3799_write-a-utility-script/function-to-automate-the-revocation-of-program-certificates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Management command to enable batch revocation of certificates. It defaults to program_certificates, which is the most likely use case, but because some UserCredentials might not be synchronized from the LMS, does allow override of the credential type.
FIXES: APER-3799