chore: remove urllib3 constraint #2648
Merged
+10
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the constraint on `urllib3` no longer downgrades boto and its dependencies. I think it is safe to remove this constraint now.
justinhynes
commented
Dec 3, 2024
Comment on lines
-19
to
-20
| # Temporary to Support the python 3.11 Upgrade | ||
| backports.zoneinfo;python_version<"3.9" # Newer versions have zoneinfo available in the standard library |
There was a problem hiding this comment.
We no longer need this constraint either now that Credentials has been updated to use Python 3.11.
jsnwesson
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the constraint on
urllib3no longer downgrades boto and its dependencies. I think it is safe to remove this constraint now.Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma