feat: remove bokchoy dependency #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed the defunct acceptance tests folder * created an external ticket (APER-2857) to see if any of these tests should be replaced * Removed bok choy dependency * removed geckodriver dependency, which seems only to have been used by bok choy, and verified that karma tests still run * ran `make upgrade` FIXES: #1989
These readme files are actually still out of date, but I'm removing the references specifically to the acceptance suite that is being flat out purged. The readme files still need updates, however. FIXES: APER-2857
deborahgu
commented
Sep 28, 2023
| @@ -42,10 +39,6 @@ container image that mimics the ones that Github Actions uses. | |||
| NOTE: The first time you run any of the test suites below, it | |||
| will build the image which will take a few minutes. Following test runs will be quicker. | |||
|
|
|||
| To run acceptance tests locally ("acceptance_tests" in CI) :: | |||
There was a problem hiding this comment.
Note: this README is still wrong w.r.t. local testing; all that's happening here is removing a reference to the now-removed, already unused test.
deborahgu
commented
Sep 28, 2023
| @@ -11,11 +11,10 @@ To make testing easier, there are a few commands that mirror our suites in CI: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| $ make acceptance_tests_suite | |||
There was a problem hiding this comment.
Note: this document is still wrong w.r.t. local testing; all that's happening here is removing a reference to the now-removed, already unused test.
deborahgu
deleted the
dkaplan1/APER-2857_remove-bok-choy-testing-framework-from-credentials
branch
irtazaakram
pushed a commit
that referenced
this pull request
Oct 3, 2023
* feat: remove bokchoy dependency * removed the defunct acceptance tests folder * created an external ticket (APER-2857) to see if any of these tests should be replaced * Removed bok choy dependency * removed geckodriver dependency, which seems only to have been used by bok choy, and verified that karma tests still run * ran `make upgrade` FIXES: #1989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make upgradeFIXES: #1989
Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma