Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bok-choy usage #1989

Closed
kdmccormick opened this issue Apr 19, 2023 · 6 comments · Fixed by #2213
Closed

Remove bok-choy usage #1989

kdmccormick opened this issue Apr 19, 2023 · 6 comments · Fixed by #2213
Assignees
@deborahgu
Labels
help wanted Ready to be picked up by anyone in the community needs maintainer attention Issue or PR specifically needs the attention of the maintainer.

Comments

@kdmccormick
Copy link
Member

This repo's acceptance tests still use the bok-choy framework, which was deprecated in Feb 2022. The bok-choy repository is no longer being maintained, and it will soon be archived.

Once the bok-choy repo is archived, the acceptance tests should continue working, as we will not be removing the package's releases from PyPI. For long-term maintainability of this repo, though, the tests should eventually be upgraded to a non-bok-choy testing framework or removed.
@kdmccormick kdmccormick mentioned this issue Apr 19, 2023
Closed
@dianakhuang dianakhuang added the help wanted Ready to be picked up by anyone in the community label Jun 29, 2023
@dianakhuang
Copy link
Contributor

dianakhuang commented Jun 29, 2023 •
edited
Loading

This removal may be blocked on the work to move the frontend code in credentials into an MFE.

We may also want to evaluate the existing credentials tests to see if we even feel like these bok choy tests are useful. We decided that they were not for edx-platform.

We should also evaluate whether or not they are being run during credentials CI.

@feanil
Copy link
Contributor

feanil commented Jun 29, 2023

@hurtstotouchfire can you help schedule this work, no rush but it just needs to get done.

@feanil
Copy link
Contributor

feanil commented Sep 6, 2023

@hurtstotouchfire FYI, we're planning on archiving the bok-choy repo in the next month. It will not receive any further updates after that including security updates. If your acceptance tests are still valuable, we strongly recommend moving them to a different testing framework.

@feanil feanil mentioned this issue Sep 6, 2023
Closed
5 tasks
@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Sep 6, 2023
@hurtstotouchfire
Copy link
Member

Thanks @feanil, adding this to our triage queue.

@jsnwesson
Copy link
Contributor

A Jira ticket was created to address this and we'll be bringing this up in our next grooming session.

@jsnwesson jsnwesson moved this from Triage to Backlog in Aperture-Maintained Sep 11, 2023
@jsnwesson
Copy link
Contributor

Update: this task is now prioritized and should hopefully be worked on in the upcoming weeks.

@jsnwesson jsnwesson moved this from Backlog to Todo in Aperture-Maintained Sep 15, 2023
@deborahgu deborahgu moved this from Todo to In Progress in Aperture-Maintained Sep 28, 2023
@deborahgu deborahgu self-assigned this Sep 28, 2023
deborahgu added a commit that referenced this issue Sep 28, 2023
@deborahgu
feat: remove bokchoy dependency
ca197fc 
* removed the defunct acceptance tests folder
* created an external ticket (APER-2857) to see if any of these tests should be replaced
* Removed bok choy dependency
* removed geckodriver dependency, which seems only to have been used by bok choy, and verified that karma tests still run
* ran `make upgrade`

FIXES: #1989
@deborahgu deborahgu mentioned this issue Sep 28, 2023
Merged
3 tasks
deborahgu added a commit that referenced this issue Sep 29, 2023
@deborahgu
feat: remove bokchoy dependency (#2213)
c98e8bd 
* feat: remove bokchoy dependency

* removed the defunct acceptance tests folder
* created an external ticket (APER-2857) to see if any of these tests should be replaced
* Removed bok choy dependency
* removed geckodriver dependency, which seems only to have been used by bok choy, and verified that karma tests still run
* ran `make upgrade`

FIXES: #1989
@github-project-automation github-project-automation bot moved this from Removing to Removed in DEPR: Deprecation & Removal Sep 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Aperture-Maintained Sep 29, 2023
irtazaakram pushed a commit that referenced this issue Oct 3, 2023
@deborahgu @irtazaakram
feat: remove bokchoy dependency (#2213)
5cbba88 
* feat: remove bokchoy dependency

* removed the defunct acceptance tests folder
* created an external ticket (APER-2857) to see if any of these tests should be replaced
* Removed bok choy dependency
* removed geckodriver dependency, which seems only to have been used by bok choy, and verified that karma tests still run
* ran `make upgrade`

FIXES: #1989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deborahgu deborahgu

Labels
help wanted Ready to be picked up by anyone in the community needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Aperture-Maintained
Status: Done
DEPR: Deprecation & Removal
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove bokchoy dependency openedx/credentials
6 participants
@deborahgu @feanil @hurtstotouchfire @dianakhuang @kdmccormick @jsnwesson