fix: add partner field to person documents #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
32
to
34
| def prepare_partner(self, obj): | ||
| return obj.partner.short_code if obj.partner else '' | ||
|
|
There was a problem hiding this comment.
should this not be added in common too?
There was a problem hiding this comment.
We could but it wouldn't be as neat since some documents have "different" implementations for it.
There was a problem hiding this comment.
If only course run has a different implementation, it makes sense to override it there. But if all others have the same pattern, it would be good to move this in common as you have done for field itself.
AfaqShuaib09
approved these changes
Nov 29, 2024
zawan-ila
force-pushed
the
anawaz/prod-4240
branch
from
3d7845d to
2bf8384
Compare
zawan-ila
force-pushed
the
anawaz/prod-4240
branch
from
2bf8384 to
25d172c
Compare
DawoudSheraz
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4240
This PR adds the partner field to person documents. This fixes the issue of person objects not being returned in GET requests against
search/alldue to the filtering in CatalogDataFilterDataMixin