Copy of - fix: use "price" in ecommerce data loader (#4450) #4459
Conversation
* chore: bump upload-artifact GH task to v4 * fix: fallback to 'price' in ecommerce api loader The Django Oscar upgrade of ecommerce changed the item's price field from `price_excl_tax` to just `price` causing the EcommerceApi data loader to fail. This commit checks for the `price_excl_tax` key and falls back to the 'price' value. Ref: openedx-unsupported/ecommerce#4050 * refactor: apply review suggestion on fix * fix: update all references of `price_excl_tax` to price * fix: remove extra item added accidentally
|
Thanks for the pull request, @tecoholic! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
|
@Ali-D-Akbar @AfaqShuaib09 Hi, I am raising this request for the master branch that we merged in redwood branch on #4450. Since the master of ecommerce uses django-oscar 3.2, I think we need to patch the master as well. |
|
@Ali-D-Akbar Hi, would you be kind enough to merge this PR? |
| @@ -573,7 +573,7 @@ def update_seats(self, body): | |||
| def update_seat(self, course_run, product_body): | |||
| stock_record = product_body['stockrecords'][0] | |||
| currency_code = stock_record['price_currency'] | |||
| price = Decimal(stock_record['price_excl_tax']) | |||
| price = Decimal(stock_record.get('price_excl_tax', stock_record['price'])) | |||
There was a problem hiding this comment.
instead of repeating this code, a util function can be added that return the price based on which argument is available. Furthermore, the docstring should explain why is there a need to check 2 keys as it wont be obvious to first time readers.
chore: bump upload-artifact GH task to v4
fix: fallback to 'price' in ecommerce api loader
The Django Oscar upgrade of ecommerce changed the
item's price field from
price_excl_taxto justpricecausing the EcommerceApi data loader to fail.This commit checks for the
price_excl_taxkey and falls back to the 'price' value.Ref: openedx-unsupported/ecommerce#4050
refactor: apply review suggestion on fix
fix: update all references of
price_excl_taxto pricefix: remove extra item added accidentally