Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

chore: Update ChromeCast for AppNav #1839

Merged
merged 2 commits into from
Nov 16, 2023
Merged

chore: Update ChromeCast for AppNav #1839

merged 2 commits into from
Nov 16, 2023

Conversation

HamzaIsrar12
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 commented Nov 13, 2023

Description

LEARNER-9687

  • Enabled video casting functionality
  • Added cast button to Video Player
  • Added cast button to Course Dashboard when connected

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (41e449f) 1.07% compared to head (fee2ba4) 1.07%.

Files Patch % Lines
...org/edx/mobile/view/CourseTabsDashboardFragment.kt 0.00% 7 Missing ⚠️
...n/java/org/edx/mobile/player/PlayerController.java 0.00% 3 Missing ⚠️
...bile/src/main/java/org/edx/mobile/util/Config.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1839      +/-   ##
===========================================
- Coverage      1.07%   1.07%   -0.01%     
  Complexity      137     137              
===========================================
  Files           538     538              
  Lines         26304   26314      +10     
  Branches       3388    3391       +3     
===========================================
  Hits            284     284              
- Misses        25993   26003      +10     
  Partials         27      27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HamzaIsrar12 HamzaIsrar12 merged commit 3012ae5 into master Nov 16, 2023
4 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-9687 branch November 16, 2023 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants