This repository has been archived by the owner on May 6, 2024. It is now read-only.
Prevent Deep Link Activation on Orientation Change #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the deep link was inadvertently activated when the fragment was recreated during an orientation change. This occurred because the screen name value was unnecessarily re-fetched from the fragment's arguments. To resolve this issue, we now set the argument to null, ensuring that deep link activation no longer occurs during orientation changes. Fixes: LEARNER-9659
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1836 +/- ##
===========================================
- Coverage 1.07% 1.07% -0.01%
Complexity 137 137
===========================================
Files 538 538
Lines 26300 26302 +2
Branches 3384 3387 +3
===========================================
Hits 284 284
- Misses 25989 25991 +2
Partials 27 27
☔ View full report in Codecov by Sentry. |
This commit disables the 'android_screenshot' job as the Instrument Test cases are currently failing. The job will remain inactive until the issues with the test cases are resolved. To re-enable the job: - Remove the 'if: false' condition from the 'android_screenshot' job - Ensure that the Instrument Test cases are functioning as expected Fixes: LEARNER-9659
Fixes: LEARNER-9659
farhan-arshad-dev
approved these changes
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9659
Previously, the deep link was inadvertently activated when the fragment was recreated during an orientation change. This occurred because the screen name value was unnecessarily re-fetched from the fragment's arguments. To resolve this issue, we now set the argument to null, ensuring that deep link activation no longer occurs during orientation changes.