-
Notifications
You must be signed in to change notification settings - Fork 35
build: add python 3.11 and 3.12 ci checks #254
build: add python 3.11 and 3.12 ci checks #254
Conversation
@feanil Hi. Can you run the workflows on this PR, please? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi I run in a fork this PR and I have 2 comments:
-
The lint commit would fail because
ci
is not in the allowed words for commitlint. You can change it totest
.
-
I want to understand if the tests would run in python 3.11 and 3.12.
Because In those tests the test_target shows 3.8
Also, I suspect in quality target tests are using the python3.8.
I think the problem is that the quality env is in python3.12, but the tests are running in the edxops/ecomworker docker image and there is 3.8.
Also this line https://github.com/openedx/ecommerce-worker/blob/f852676a216b35ee845af66eb142ff657d72f98f/.github/workflows/ci.yml#L33
The python3-dev package seems installing with python3.8
@Danyal-Faheem looks like you need to fix the commit messages so the conform to OEP-51 and rebase this on top of master and then it should be good to merge. Let me know when that's done and I can help land it. |
Hey Feanil. It needs some changes in Dockerfile (just like Discovery and e-commerce repositories). It's on our radar, we will try to get it done as soon as possible. Once merged, we will backport this to redwood.master. |
b51300d
to
c823f22
Compare
Hi @feanil, I've made the required changes, can you trigger the workflows here and also review this PR for me? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tox would enforce python3.8 without this change Now we install tox in that specific python and then run tox from it
6e486ff
to
22b6df1
Compare
Hi @feanil, this PR is ready to be merged. Can you take a look and merge this for me? Thanks. |
@Danyal-Faheem please tag me on the backport PR as well though I think the BTR release manager can merge that as well I just want to know when it lands. |
Changes
docker-compose
todocker compose
.⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
If you're merging to master (not 2u/main) branch...
Merge checklist:
requirements/*.txt
files)base.in
if needed in productiontest.in
for test requirementsmake upgrade && make requirements
have been run to regenerate requirementsPost merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in ecommerce will look for the latest version in PyPi.ecommerce
ecomworker