Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update e2e-fio #111

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: update e2e-fio #111

merged 1 commit into from
Jan 7, 2025

Conversation

blaisedias
Copy link
Collaborator

Regularise command enum members (do not mix with #defines) Update comments in e2e-fio.c for clarity
Updated readme
bump version number as code has changed a tuiny bit

@blaisedias
Copy link
Collaborator Author

Tested manually with export e2e_fio_image=ci-registry.mayastor-ci.mayadata.io/openebs/e2e-fio:v3.38-e2e-1
smoketest and selfci

@rohan2794 rohan2794 requested a review from dsharma-dc January 6, 2025 09:03
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My C is a bit rusty, but seems plausible

tools/e2e-fio/e2e_fio.c Outdated Show resolved Hide resolved
tools/e2e-fio/e2e_fio.c Show resolved Hide resolved
@blaisedias blaisedias force-pushed the e2e-fio-update branch 5 times, most recently from 29f0060 to 91f539e Compare January 7, 2025 10:02
Regularise command enum members (do not mix with #defines)
Update comments in e2e-fio.c for clarity
Updated readme
bump version number as code has changed a tuiny bit

Change symbol KW_MAKEFILE to KW_CREATEFILE
the string associated with the symbol will be retained
as "makefile"

Signed-off-by: Blaise Dias <[email protected]>
@blaisedias blaisedias merged commit 3030a06 into develop Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants