Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add utils for statefulset pods #105

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add utils for statefulset pods #105

wants to merge 1 commit into from

Conversation

w3aman
Copy link
Collaborator

@w3aman w3aman commented Dec 9, 2024

  • This PR adds couple of util functions to
  1. get sts pod names
  2. check if a pod is deleted successfully

@w3aman w3aman force-pushed the sts_functions branch 2 times, most recently from 6e8b362 to 5452521 Compare December 9, 2024 07:09
blaisedias
blaisedias approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@blaisedias blaisedias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But see comment

common/k8stest/util_pod.go
}

func WaitForPodDeletion(podName string, namespace string) (bool, error) {
timeout := 90 * time.Second // Set timeout to 90 seconds
Copy link
Collaborator

@blaisedias blaisedias Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to make timeout an input parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r1jt r1jt r1jt approved these changes

@rohan2794 rohan2794 rohan2794 approved these changes

@blaisedias blaisedias blaisedias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w3aman @blaisedias @rohan2794 @r1jt