Skip to content

fix: support IPv6 in replica address discovery #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
margau wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: support IPv6 in replica address discovery #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/replica.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ package app

import (
"errors"
"fmt"
"net"
"net/http"
"os"
Expand Down Expand Up @@ -293,6 +294,7 @@ func startReplica(c *cli.Context) error {
host, _ := os.Hostname()
addrs, _ := net.LookupIP(host)
for _, addr := range addrs {
// first try: handle addr as v4 address
if ipv4 := addr.To4(); ipv4 != nil {
address = ipv4.String()
if address == "127.0.0.1" {
Expand All @@ -301,7 +303,17 @@ func startReplica(c *cli.Context) error {
}
address = address + ":9502"
break
} else if ipv6 := addr.To16(); ipv6 != nil {
// second try: handle addr as v6 address only if we know it is not v4
address = ipv6.String()
if address == "::1" {
address = fmt.Sprintf("[%s]:9502", address)
continue
}
address = fmt.Sprintf("[%s]:9502", address)
break
}

}
}
controlAddress, dataAddress, syncAddress, err := util.ParseAddresses(address)
Expand Down