Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Raw kserve auth #91

Merged
merged 16 commits into from
Jan 30, 2025
Merged

Add test for Raw kserve auth #91

merged 16 commits into from
Jan 30, 2025

Conversation

mwaykole
Copy link
Member

@mwaykole mwaykole commented Jan 11, 2025 •
edited
Loading

Test Covered

  1. Verify RAW Kserve model query with token using REST
  2. Verify model query after authentication is disabled

[WIP] add test for Raw kserve auth
bf097b4 
Signed-off-by: Milind Waykole <[email protected]>
@github-actions GitHub Actions
Copy link

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/wip', '/verified', '/hold', '/lgtm'}

[WIP] add test for Raw kserve auth
906b6ec 
Signed-off-by: Milind Waykole <[email protected]>
[WIP] add test for Raw kserve auth
9398257 
Signed-off-by: Milind Waykole <[email protected]>
@mwaykole mwaykole changed the title [WIP] add test for Raw kserve auth Add test for Raw kserve auth Jan 29, 2025
Milind Waykole added 4 commits January 29, 2025 17:21
@github-actions github-actions bot added size/xxl and removed size/l labels Jan 29, 2025
@mwaykole mwaykole force-pushed the test_raw_auth branch 2 times, most recently from 03b0517 to 3b6b713 Compare January 29, 2025 12:23
@github-actions github-actions bot added size/l and removed size/xxl labels Jan 29, 2025
Milind Waykole and others added 2 commits January 29, 2025 19:55
@mwaykole mwaykole added the Verified Verified pr in Jenkins label Jan 29, 2025
@mwaykole mwaykole requested a review from rnetser January 29, 2025 15:56
rnetser
rnetser requested changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@rnetser rnetser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the grpc fixtures until they are used.

tests/model_serving/model_server/authentication/conftest.py Outdated Show resolved Hide resolved
tests/model_serving/model_server/authentication/conftest.py Outdated Show resolved Hide resolved
tests/model_serving/model_server/authentication/conftest.py Outdated Show resolved Hide resolved
tests/model_serving/model_server/authentication/conftest.py Outdated Show resolved Hide resolved
tests/model_serving/model_server/authentication/conftest.py Outdated Show resolved Hide resolved
tests/model_serving/model_server/authentication/conftest.py Outdated Show resolved Hide resolved
tests/model_serving/model_server/authentication/conftest.py Outdated Show resolved Hide resolved
tests/model_serving/model_server/authentication/test_kserve_token_authentication_raw.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/xxl and removed size/l Verified Verified pr in Jenkins labels Jan 30, 2025
addressed comments
58da56e 
Signed-off-by: Milind Waykole <[email protected]>
@github-actions github-actions bot added size/xl and removed size/xxl labels Jan 30, 2025
addressed comments
291e10a 
Signed-off-by: Milind Waykole <[email protected]>
@github-actions github-actions bot added size/xxl and removed size/xl labels Jan 30, 2025
addressed comments
980bc0f 
Signed-off-by: Milind Waykole <[email protected]>
@mwaykole mwaykole requested a review from rnetser January 30, 2025 10:01
@mwaykole
Copy link
Member Author

test

@mwaykole
Copy link
Member Author

/retest

rnetser
rnetser previously approved these changes Jan 30, 2025
View reviewed changes
addressed comments
cfac82a 
Signed-off-by: Milind Waykole <[email protected]>
@github-actions github-actions bot added size/l and removed size/xxl labels Jan 30, 2025
@rnetser rnetser merged commit 768cdc3 into opendatahub-io:main Jan 30, 2025
5 of 6 checks passed
adolfo-ab pushed a commit to adolfo-ab/opendatahub-tests that referenced this pull request Feb 3, 2025
@mwaykole @pre-commit-ci @adolfo-ab
Add test for Raw kserve auth (opendatahub-io#91)
5f77806 
* [WIP] add test for Raw kserve auth

Signed-off-by: Milind Waykole <[email protected]>

* [WIP] add test for Raw kserve auth

Signed-off-by: Milind Waykole <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [WIP] add test for Raw kserve auth

Signed-off-by: Milind Waykole <[email protected]>

* [WIP] add test for Raw kserve auth

Signed-off-by: Milind Waykole <[email protected]>

* [WIP] add test for Raw kserve auth

Signed-off-by: Milind Waykole <[email protected]>

* [WIP] add test for Raw kserve auth

Signed-off-by: Milind Waykole <[email protected]>

* [WIP] add test for Raw kserve auth

Signed-off-by: Milind Waykole <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* addressed comments

Signed-off-by: Milind Waykole <[email protected]>

* addressed comments

Signed-off-by: Milind Waykole <[email protected]>

* addressed comments

Signed-off-by: Milind Waykole <[email protected]>

* addressed comments

Signed-off-by: Milind Waykole <[email protected]>

* addressed comments

Signed-off-by: Milind Waykole <[email protected]>

---------

Signed-off-by: Milind Waykole <[email protected]>
Co-authored-by: Milind Waykole <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnetser rnetser rnetser approved these changes

Assignees
No one assigned
Labels
commented-by-mwaykole size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwaykole @rnetser