Add first Model Registry tests #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
|
Needs RedHatQE/openshift-python-wrapper#2220 to be merged first |
Signed-off-by: lugi0 <[email protected]>
tarukumar
reviewed
Dec 10, 2024
tarukumar
reviewed
Dec 10, 2024
|
overall looks good. Add small comment |
adolfo-ab
reviewed
Dec 10, 2024
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
adolfo-ab
previously approved these changes
Dec 11, 2024
tarukumar
previously approved these changes
Dec 11, 2024
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
rnetser
requested changes
Dec 12, 2024
Signed-off-by: lugi0 <[email protected]>
rnetser
requested changes
Dec 15, 2024
rnetser
reviewed
Dec 15, 2024
rnetser
requested changes
Dec 15, 2024
Signed-off-by: lugi0 <[email protected]>
adolfo-ab
previously approved these changes
Dec 18, 2024
tarukumar
previously approved these changes
Dec 18, 2024
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
|
Do not merge right now, still needs testing |
rnetser
requested changes
Dec 22, 2024
| @@ -23,14 +23,14 @@ class TestDriftMetrics: | |||
| def test_send_inference_request_and_verify_trustyai_service( | |||
| self, | |||
| admin_client, | |||
| openshift_token, | |||
| current_client_token, | |||
There was a problem hiding this comment.
openshift_token should be deleted
There was a problem hiding this comment.
Do you mean the fixture?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Merge criteria: