[WIP] Add support for MariaDB in TrustyAI tests #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnetser
requested changes
Dec 12, 2024
| def mariadb_operator_cr(admin_client: DynamicClient) -> MariadbOperator: | ||
| mariadb_csv = get_cluster_service_version(client=admin_client, prefix="mariadb", namespace=OPENSHIFT_OPERATORS) | ||
| alm_examples = mariadb_csv.get_alm_examples() | ||
| mariadb_operator_cr_dict = next(d for d in alm_examples if d["kind"] == "MariadbOperator") |
There was a problem hiding this comment.
please avoid using one-letter vars so it is clear to someone looking at the code what is d
| client=admin_client, prefix="mariadb", namespace=OPENSHIFT_OPERATORS | ||
| ) | ||
| alm_examples: List[Dict[str, Any]] = mariadb_csv.get_alm_examples() | ||
| mariadb_dict: Dict[str, Any] = next(d for d in alm_examples if d["kind"] == "MariaDB") |
Comment on lines
+66
to
+67
| except TimeoutExpiredError as exc: | ||
| raise exc |
There was a problem hiding this comment.
no need to raise, the sampler will do it
adolfo-ab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Merge criteria: