[WIP] fix isvc for all kind of storage #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milind Waykole <[email protected]>
for more information, see https://pre-commit.ci
rnetser
reviewed
Nov 6, 2024
| storage_uri: str, | ||
| model_format: str, | ||
| runtime: str, | ||
| min_replicas: int = 1, | ||
| max_replicas: Optional[int] = 1, |
There was a problem hiding this comment.
"""Optional[X] is equivalent to Union[X, None].""" so should be
Suggested change
| max_replicas: Optional[int] = 1, | |
| max_replicas: Optional[int] = None, |
and in the code, add to the dict if max_replicas is not None
Comment on lines
+20
to
+23
| cpu_limit: str = "2", | ||
| memory_limit: str = "8Gi", | ||
| cpu_request: str = "1", | ||
| memory_request: str = "4Gi", |
There was a problem hiding this comment.
why do we want to set these defaults? why not have the same values set for limits and requests? what happens if you do not set defaults?
|
|
||
| if model_service_account: | ||
| predictor_config["serviceAccountName"] = model_service_account | ||
|
|
There was a problem hiding this comment.
base_annotations = {
"serving.kserve.io/deploymentMode": deployment_mode,
}
if deployment_mode == "RawDeployment":
annotations = base_annotations
....
else:
annotations = base_annotations.update(....)
| } | ||
| labels = { | ||
| "networking.kserve.io/visibility": "enable-route", | ||
| "security.opendatahub.io/enable-auth": "true", |
There was a problem hiding this comment.
should be set based on enable_auth right?
| "networking.kserve.io/visibility": "enable-route", | ||
| "security.opendatahub.io/enable-auth": "true", | ||
| } | ||
| else: |
There was a problem hiding this comment.
"""
elif deployment_mode == "Serverless"
"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is func should work with AWS , GCP , OCI stoarge