addressed comments

Signed-off-by: Milind Waykole <[email protected]>
opendatahub-io · Jan 30, 2025 · 980bc0f · 980bc0f
1 parent 291e10a
commit 980bc0f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/tests/model_serving/model_server/authentication/conftest.py b/tests/model_serving/model_server/authentication/conftest.py
@@ -26,6 +26,7 @@
 )
 from utilities.serving_runtime import ServingRuntimeFromTemplate
 from utilities.constants import Annotations
+from utilities.constants import Labels
 
 
 # GRPC model serving
@@ -181,7 +182,7 @@ def patched_remove_raw_authentication_isvc(
         patches={
             http_s3_caikit_raw_inference_service: {
                 "metadata": {
-                    "annotations": {Annotations.KserveAuth.SECURITY: "false"},
+                    "labels": {Labels.KserveAuth.SECURITY: "false"},
                 }
             }
         }

diff --git a/tests/model_serving/model_server/utils.py b/tests/model_serving/model_server/utils.py
@@ -12,6 +12,7 @@
 from utilities.constants import (
     Annotations,
     KServeDeploymentType,
+    Labels,
 )
 from utilities.exceptions import (
     FailedPodsError,
@@ -129,9 +130,9 @@ def create_isvc(
     if enable_auth:
         # model mesh auth is set in servingruntime
         if deployment_mode == KServeDeploymentType.SERVERLESS:
-            annotations["security.opendatahub.io/enable-auth"] = "true"
+            annotations[Annotations.KserveAuth.SECURITY] = "true"
         elif deployment_mode == KServeDeploymentType.RAW_DEPLOYMENT:
-            labels["security.opendatahub.io/enable-auth"] = "true"
+            labels[Labels.KserveAuth.SECURITY] = "true"
 
     # default to True if deployment_mode is Serverless (default behavior of Serverless) if was not provided by the user
     # model mesh external route is set in servingruntime