fix: add matchlabel on NWP for customized appliation #1566
Conversation
- update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]>
zdtsw
force-pushed
the
chore_fix_appns2
branch
from
0a9c990 to
f69493d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
+ Coverage 19.84% 19.92% +0.08%
==========================================
Files 159 159
Lines 10794 10805 +11
==========================================
+ Hits 2142 2153 +11
Misses 8424 8424
Partials 228 228 ☔ View full report in Codecov by Sentry. |
|
|
||
| To upgrade, follow these steps: | ||
|
|
||
| - Disable the component(s) in your DSC instance. |
There was a problem hiding this comment.
Do we need to deactivate the components, or does deleting the DSC do the same thing?
There was a problem hiding this comment.
this is an old upgrade case since we have changes in 2.0/2.1 to 2.4 GA version.
most of the current user should not encounter this, unless they have been on 2.0/2.1 for 1.5yrs?
maybe we can revisit these documents and clean up some later
There was a problem hiding this comment.
Sounds good, we can revisit and clean them up later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ugiordan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a00aa61
into
opendatahub-io:main
| Here we use namespace A for example as targeted application namespace, please follow below steps before install ODH operator: | ||
|
|
||
| - create namespace A | ||
| - add label `opendatahub.io/application-namespace: true` onto namespace A. Only one namespace in the cluster can have this label. |
There was a problem hiding this comment.
feel free to use suggestion for code review next time.
i can get that change committed if it is needed. now seems a bit too late :D
|
@shalberd FYI |
|
thank you very much |
| @@ -233,6 +233,17 @@ func (r *DSCInitializationReconciler) reconcileDefaultNetworkPolicy( | |||
| }, | |||
| }, | |||
| }, | |||
| { // OR logic to minic customized application namespace | |||
There was a problem hiding this comment.
logical or, either traffic within 2generated" labeled namespace or namespace that has the application namespace label.
Nice, thank you.
…1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit a00aa61)
…1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit a00aa61) Signed-off-by: Wen Zhou <[email protected]>
- update README and troubleshooting (cherry picked from commit a00aa61) Signed-off-by: Wen Zhou <[email protected]>
Description
https://issues.redhat.com/browse/RHOAIENG-18607?focusedId=26467211&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-26467211
How Has This Been Tested?
Screenshot or short clip
Merge criteria